Closed
Conversation
dpgaspar
approved these changes
Apr 9, 2020
Member
Author
|
Travis has passed CI but the status wasn't reported to Github :( |
Member
|
Travis is currently almost doing more harm than good. |
Member
Author
|
Agreed. We're going to try to support the Github Actions work next week. |
Member
Author
|
OK, build passed again, still no status update from Travis. Does anyone have admin access to merge in this type of situation? |
Member
|
It seems once GH drops Travis like this, there's no coming back. It's not elegant I know, but I propose closing this and opening a new PR, as this is a pretty critical fix. |
Member
Author
|
OK, closing + reopening. |
This was referenced Apr 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The lines altered in this PR were introduced 8 days ago in this commit: f0f4f7e
These lines broke
the Multi Line visualization, as that visualization has no
from_dttmorto_dttmattributes. MultiLine visualizations on current master display the error'MultiLineViz object has no attribute 'from_dttm'.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
I've manually tested the change locally. You can verify the fix by navigating to:
Dashbaoards -> Misc Charts
and scrolling to the bottom where the "Multi Line" chart is displayed.
ADDITIONAL INFORMATION
REVIEWERS
@villebro @dpgaspar @ktmud